Closed Bug 1596245 Opened 6 years ago Closed 6 years ago

AddressSanitizer: access-violation z:\build\build\src\dom\webgpu\Device.cpp:27 in mozilla::webgpu::Device::~Device

Categories

(Core :: Graphics: WebGPU, defect, P2)

Product:
Core
Component:
Graphics: WebGPU
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox71 --- unaffected
firefox72 --- fixed

People

(Reporter: nataliaCs, Assigned: kvark)

References

(Blocks 1 open bug)

Details

(Keywords: csectype-nullptr)

Crash Data

Attachments

(1 file)

Fix WebGPU device destruction
47 bytes, text/x-phabricator-request
Details | Review

Push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a64b015e2fb96ffa9f5a4b2bde94752f7ed2fe2b&searchStr=windows%2C10%2Cx64%2Casan%2Cmochitests%2Ctest-windows10-64-asan%2Fopt-mochitest-webgl1-core-e10s%2Cm%28gl1c%29&selectedJob=276055640

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276055640&repo=autoland&lineNumber=5572

Task details: https://firefox-ci-tc.services.mozilla.com/tasks/GFWyIIyDQoegdtOpCZXOgA

>[task 2019-11-13T19:01:16.128Z] 19:01:16     INFO - GECKO(5860) | =================================================================
[task 2019-11-13T19:01:16.128Z] 19:01:16    ERROR - GECKO(5860) | ==4660==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000050 (pc 0x7ffc02dff889 bp 0x02d6f0d80000 sp 0x00d80e5fe760 T0)
[task 2019-11-13T19:01:16.129Z] 19:01:16     INFO - GECKO(5860) | ==4660==The signal is caused by a READ memory access.
[task 2019-11-13T19:01:16.129Z] 19:01:16     INFO - GECKO(5860) | ==4660==Hint: address points to the zero page.
[task 2019-11-13T19:01:16.409Z] 19:01:16     INFO - GECKO(5860) | 1573671676401	Marionette	TRACE	Received observer notification xpcom-will-shutdown
[task 2019-11-13T19:01:16.409Z] 19:01:16     INFO - GECKO(5860) | 1573671676401	Marionette	INFO	Stopped listening on port 2828
[task 2019-11-13T19:01:16.409Z] 19:01:16     INFO - GECKO(5860) | 1573671676401	Marionette	DEBUG	Remote service is inactive
[task 2019-11-13T19:01:16.530Z] 19:01:16     INFO - GECKO(5860) | [GPU 5316, Chrome_ChildThread] WARNING: pipe error: 109: file z:/
[task 2019-11-13T19:01:16.531Z] 19:01:16     INFO - GECKO(5860) | ###!!! [Child][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2019-11-13T19:01:16.533Z] 19:01:16     INFO - GECKO(5860) | build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-11-13T19:01:16.535Z] 19:01:16     INFO - GECKO(5860) | [Parent 5200, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-11-13T19:01:16.633Z] 19:01:16     INFO - GECKO(5860) | ==4660==WARNING: Failed to use and restart external symbolizer!
[task 2019-11-13T19:01:16.906Z] 19:01:16     INFO - GECKO(5860) |     #0 0x7ffc02dff888 in mozilla::webgpu::Device::~Device z:\build\build\src\dom\webgpu\Device.cpp:27
[task 2019-11-13T19:01:16.906Z] 19:01:16     INFO - GECKO(5860) |     #1 0x7ffc02e0182f in mozilla::webgpu::Device::~Device z:\build\build\src\dom\webgpu\Device.cpp:26
[task 2019-11-13T19:01:16.911Z] 19:01:16     INFO - GECKO(5860) |     #2 0x7ffbfbb5b1de in SnowWhiteKiller::~SnowWhiteKiller z:\build\build\src\xpcom\base\nsCycleCollector.cpp:2416
[task 2019-11-13T19:01:16.912Z] 19:01:16     INFO - GECKO(5860) |     #3 0x7ffbfbb64b7a in nsCycleCollector::BeginCollection z:\build\build\src\xpcom\base\nsCycleCollector.cpp:3584
[task 2019-11-13T19:01:16.912Z] 19:01:16     INFO - GECKO(5860) |     #4 0x7ffbfbb63d45 in nsCycleCollector::Collect z:\build\build\src\xpcom\base\nsCycleCollector.cpp:3413
[task 2019-11-13T19:01:16.912Z] 19:01:16     INFO - GECKO(5860) |     #5 0x7ffbfbb6358b in nsCycleCollector::ShutdownCollect z:\build\build\src\xpcom\base\nsCycleCollector.cpp:3357
[task 2019-11-13T19:01:16.912Z] 19:01:16     INFO - GECKO(5860) |     #6 0x7ffbfbb66145 in nsCycleCollector::Shutdown z:\build\build\src\xpcom\base\nsCycleCollector.cpp:3645
[task 2019-11-13T19:01:16.917Z] 19:01:16     INFO - GECKO(5860) |     #7 0x7ffbfbb69a64 in nsCycleCollector_shutdown z:\build\build\src\xpcom\base\nsCycleCollector.cpp:3960
[task 2019-11-13T19:01:16.922Z] 19:01:16     INFO - GECKO(5860) |     #8 0x7ffbfbe0a322 in mozilla::ShutdownXPCOM z:\build\build\src\xpcom\build\XPCOMInit.cpp:707
[task 2019-11-13T19:01:16.927Z] 19:01:16     INFO - GECKO(5860) |     #9 0x7ffc097c2230 in XRE_TermEmbedding z:\build\build\src\toolkit\xre\nsEmbedFunctions.cpp:223
[task 2019-11-13T19:01:16.946Z] 19:01:16     INFO - GECKO(5860) |     #10 0x7ffbfcfee1f8 in mozilla::ipc::ScopedXREEmbed::Stop z:\build\build\src\ipc\glue\ScopedXREEmbed.cpp:90
[task 2019-11-13T19:01:16.946Z] 19:01:16     INFO - GECKO(5860) |     #11 0x7ffc097c34c6 in XRE_InitChildProcess z:\build\build\src\toolkit\xre\nsEmbedFunctions.cpp:773
[task 2019-11-13T19:01:16.947Z] 19:01:16     INFO - GECKO(5860) |     #12 0x7ff64d2e20d8 in NS_internal_main z:\build\build\src\browser\app\nsBrowserApp.cpp:272
[task 2019-11-13T19:01:16.947Z] 19:01:16     INFO - GECKO(5860) |     #13 0x7ff64d2e1501 in wmain z:\build\build\src\toolkit\xre\nsWindowsWMain.cpp:131
[task 2019-11-13T19:01:16.947Z] 19:01:16     INFO - GECKO(5860) |     #14 0x7ff64d3dd6d7 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:288
[task 2019-11-13T19:01:16.948Z] 19:01:16     INFO - GECKO(5860) |     #15 0x7ffc54003033 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180013033)
[task 2019-11-13T19:01:16.948Z] 19:01:16     INFO - GECKO(5860) |     #16 0x7ffc54831460 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180071460)
[task 2019-11-13T19:01:16.948Z] 19:01:16     INFO - GECKO(5860) | AddressSanitizer can not provide additional info.
[task 2019-11-13T19:01:16.949Z] 19:01:16     INFO - GECKO(5860) | SUMMARY: AddressSanitizer: access-violation z:\build\build\src\dom\webgpu\Device.cpp:27 in mozilla::webgpu::Device::~Device
[task 2019-11-13T19:01:16.949Z] 19:01:16     INFO - GECKO(5860) | ==4660==ABORTING
[task 2019-11-13T19:01:17.494Z] 19:01:17     INFO - GECKO(5860) | [GPU 5316, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 341
[task 2019-11-13T19:01:18.872Z] 19:01:18     INFO - TEST-INFO | Main app process: exit 0

*entering test: TEST-START | Shutdown*

Looks like a null deref

Group: core-security
Component: Graphics → Canvas: WebGL
Flags: needinfo?(jgilbert)
Keywords: csectype-nullptr
Assignee: nobody → dmalyshau
Component: Canvas: WebGL → Graphics: WebGPU
Priority: -- → P2

Looking

Flags: needinfo?(jgilbert)
Crash Signature: [@ mozilla::webgpu::Device::~Device()]
Pushed by dmalyshau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80763bd78330 Fix WebGPU device destruction r=jgilbert

https://hg.mozilla.org/mozilla-central/rev/80763bd78330

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox72: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

This is new code, not a regression.

Keywords: regression

Actually, it looks like the issue is still there - https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276357659&repo=try&lineNumber=5412

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

No, it's fixed. Was just looking a try of a separate change I was doing that went in independently.
The proper try for this fix was https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e90bf4a4cfa7b3812af2223ba5d7b1d936b876a, and it's green.

Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED

== Change summary for alert #23967 (as of Fri, 15 Nov 2019 09:02:17 GMT) ==

Improvements:

5% raptor-tp6-linkedin-firefox fcp linux64-shippable-qr opt 577.27 -> 549.25
4% raptor-tp6-linkedin-firefox linux64-shippable-qr opt 720.12 -> 688.25
4% raptor-tp6-linkedin-firefox fcp linux64-shippable opt 550.33 -> 527.92
4% raptor-tp6-yahoo-mail-firefox loadtime linux64-shippable opt 414.85 -> 398.54
4% raptor-tp6-google-mail-firefox loadtime linux64-shippable-qr opt 440.67 -> 423.38
4% raptor-tp6-facebook-firefox fcp linux64-shippable-qr opt 309.65 -> 298.12
4% raptor-tp6-linkedin-firefox linux64-shippable opt 684.73 -> 660.03
4% raptor-tp6-yahoo-mail-firefox loadtime linux64-shippable-qr opt 430.79 -> 415.54
3% raptor-tp6-google-mail-firefox loadtime linux64-shippable opt 415.00 -> 402.92
3% raptor-tp6-facebook-firefox linux64-shippable-qr opt 322.66 -> 313.49
2% raptor-tp6-binast-instagram-firefox loadtime linux64-shippable opt 467.00 -> 456.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23967

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: